r/Bitcoin: reviewing the commits that introduced the entropy bug
reddit-entropy-bug-commits-review
https://www.reddit.com/r/Bitcoin/comments/1vdycb4/coldcard_entropy_bug_the_commits_that_introduced/
Latest reviewed change
source content difference between and
Reddit no longer served a comment arguing that the commits showed shortcuts compared with the review process at the author's workplace.
body:
Like the Linux kernel
-comment: p1dj4p1
-parent: t1_p1dgscs
-author: OldHamburger7923
-created_utc: 1785725606
-edited: false
First lines only. The complete diff is in the timeline below.
- Organisation
- Evidence role
- Community discussion
- Published
- not established
- Source changes
- 4
- Detected differences
- 4
- Unreviewed
- 0
- Copies held
- 5
Every check is recorded, including checks that found no text change. A detected edit is therefore bounded between two checks. The publisher's exact save time is not observable from this record. Last checked .
This post is held twice: here, with this project's own note on why it matters, and again as part of the conversation captured at , which is polled for changes. Both copies are the same post; neither is a separate event.
Snapshot and diff bodies for this chain monitor are held in the local evidence archive but withheld from the public site because they can contain the addresses of people who published nothing themselves. Capture times and reviewed change summaries remain available below.
Held captures
-
Reddit no longer served a comment arguing that the commits showed shortcuts compared with the review process at the author's workplace.
Recovered from the Internet Archive rather than captured by this project. The row records that third-party provenance separately from captures made by this project.
What changed from the previous capture 8 lines
body: Like the Linux kernel -comment: p1dj4p1 -parent: t1_p1dgscs -author: OldHamburger7923 -created_utc: 1785725606 -edited: false -body: -it goes to show they were taking shortcuts. In my workplace, git is hooked into the feature tracker, your commit messages go into the release, release notes info, and is read by more than just your code reviewer. - comment: p1dlx6a parent: t1_p1dhn2p author: user_name_checks_outExtracted text as captured
post: 1vdycb4 author: DyehuthyTV created_utc: 1785717011 title: Coldcard entropy bug: the commits that introduced it are worth reviewing body: Source → X (Tweet): [hodlonaut #BIP-110 on X: "The commits (code changes)..." / X](https://x.com/hodlonaut/status/2083885515229573203) 👀 This is why people should learn to **VERIFY the things they consume**. No excuses! >"I am not a programmer, I don't understand code. How am I supposed to verify?" Learn! With Bitcoin, you are adopting a living standard of verifying everything: **understanding how things really work.** * Economics * Monetary system(fiat money) * Banking system * Investing & Saving * Software * Hardware * Information (facts vs noise) * Privacy * Cybersecurity * etc., etc. This living standard is not just for "paranoids." It is for people who like to do their own research and their own due diligence. **"Don't trust, verify" is not a slogan. It is a living standard!** **"With Bitcoin, you are your own bank."** Well, this is a huge responsibility! It is not a "game." You have to invest a lot of time into **security**, just like banks do. comment: p1czpje parent: t3_1vdycb4 author: CheeseWeezel created_utc: 1785718716 edited: false body: I've never heard of anyone comparing commit message length to the amount of code changes. Every production system I've ever worked on inevitably has an occasional "WIP", "Ugh", or "Crap" commit message - just how it works.Excerpt only. The complete copy is held offline and backs quotations on this site. The original publication remains the canonical public source.
-
An existing Reddit comment changed or its author account was deleted.
Recovered from the Internet Archive rather than captured by this project. The row records that third-party provenance separately from captures made by this project.
What changed from the previous capture 26 lines
parent: t1_p1pduwo author: DyehuthyTV created_utc: 1785870947 -edited: false -body: - Have you ever read a PR in a big project? lol xD - -Example, from Bitcoin Core (Node) repo on Github: [Pull requests · bitcoin/bitcoin](https://github.com/bitcoin/bitcoin/pulls) 👀 +edited: 1785871211 +body: +Have you ever read a PR in a big project? lol xD + +Example, from Bitcoin Core (Node) repo on Github: [Pull requests · bitcoin/bitcoin](https://github.com/bitcoin/bitcoin/pulls) (Github Link) 👀 Commit: <type/scope (dir)>: <description> 👇🏻 You cant put a commits like this 👇🏻 -`Windows` or `Crap` - -xD lol, is non-professional - -Plus a comment explaining the the reason (bug, fix, error, typo, etc) and the logic of your PR. - -Read the CONTRIBUTING file, before talking about it lol +`Windows` or `Crap` + +xD lol, is non-professional + +Plus a comment explaining the reason (bug, fix, error, typo, etc) and the logic of your PR. + +**There is much more descriptive content (commits + comments) in a PR than people who have never worked as developers believe ;)** + +**Read the CONTRIBUTING file, before talking about it lol**Extracted text as captured
post: 1vdycb4 author: DyehuthyTV created_utc: 1785717011 title: Coldcard entropy bug: the commits that introduced it are worth reviewing body: Source → X (Tweet): [hodlonaut #BIP-110 on X: "The commits (code changes)..." / X](https://x.com/hodlonaut/status/2083885515229573203) 👀 This is why people should learn to **VERIFY the things they consume**. No excuses! >"I am not a programmer, I don't understand code. How am I supposed to verify?" Learn! With Bitcoin, you are adopting a living standard of verifying everything: **understanding how things really work.** * Economics * Monetary system(fiat money) * Banking system * Investing & Saving * Software * Hardware * Information (facts vs noise) * Privacy * Cybersecurity * etc., etc. This living standard is not just for "paranoids." It is for people who like to do their own research and their own due diligence. **"Don't trust, verify" is not a slogan. It is a living standard!** **"With Bitcoin, you are your own bank."** Well, this is a huge responsibility! It is not a "game." You have to invest a lot of time into **security**, just like banks do. comment: p1czpje parent: t3_1vdycb4 author: CheeseWeezel created_utc: 1785718716 edited: false body: I've never heard of anyone comparing commit message length to the amount of code changes. Every production system I've ever worked on inevitably has an occasional "WIP", "Ugh", or "Crap" commit message - just how it works.Excerpt only. The complete copy is held offline and backs quotations on this site. The original publication remains the canonical public source.
-
The Reddit thread gained 2 new comments.
Recovered from the Internet Archive rather than captured by this project. The row records that third-party provenance separately from captures made by this project.
What changed from the previous capture 34 lines
edited: false body: Most big names are all hat and no cattle. What exactly did he do to warrant that reverence? + +comment: p1pduwo +parent: t1_p1da4ay +author: magicmulder +created_utc: 1785869345 +edited: false +body: +\> with that "squashing commits" approach, you will never make a "code change" + +No, that is literally how it works. The reviewer looks at your PR with its commits and commit messages, and once the PR is accepted, nobody ever sees those commits again because nobody wants 825 commit messages "fixed dumb bug from yesterday" from a single PR in the dev or main branch, that's just noise. + +comment: p1pk4cd +parent: t1_p1pduwo +author: DyehuthyTV +created_utc: 1785870947 +edited: false +body: + Have you ever read a PR in a big project? lol xD + +Example, from Bitcoin Core (Node) repo on Github: [Pull requests · bitcoin/bitcoin](https://github.com/bitcoin/bitcoin/pulls) 👀 + +Commit: <type/scope (dir)>: <description> 👇🏻 + +`util: set os-level thread names on Windows- #number` + +You cant put a commits like this 👇🏻 + +`Windows` or `Crap` + +xD lol, is non-professional + +Plus a comment explaining the the reason (bug, fix, error, typo, etc) and the logic of your PR. + +Read the CONTRIBUTING file, before talking about it lolExtracted text as captured
post: 1vdycb4 author: DyehuthyTV created_utc: 1785717011 title: Coldcard entropy bug: the commits that introduced it are worth reviewing body: Source → X (Tweet): [hodlonaut #BIP-110 on X: "The commits (code changes)..." / X](https://x.com/hodlonaut/status/2083885515229573203) 👀 This is why people should learn to **VERIFY the things they consume**. No excuses! >"I am not a programmer, I don't understand code. How am I supposed to verify?" Learn! With Bitcoin, you are adopting a living standard of verifying everything: **understanding how things really work.** * Economics * Monetary system(fiat money) * Banking system * Investing & Saving * Software * Hardware * Information (facts vs noise) * Privacy * Cybersecurity * etc., etc. This living standard is not just for "paranoids." It is for people who like to do their own research and their own due diligence. **"Don't trust, verify" is not a slogan. It is a living standard!** **"With Bitcoin, you are your own bank."** Well, this is a huge responsibility! It is not a "game." You have to invest a lot of time into **security**, just like banks do. comment: p1czpje parent: t3_1vdycb4 author: CheeseWeezel created_utc: 1785718716 edited: false body: I've never heard of anyone comparing commit message length to the amount of code changes. Every production system I've ever worked on inevitably has an occasional "WIP", "Ugh", or "Crap" commit message - just how it works.Excerpt only. The complete copy is held offline and backs quotations on this site. The original publication remains the canonical public source.
-
The Reddit thread gained 1 new comment.
Recovered from the Internet Archive rather than captured by this project. The row records that third-party provenance separately from captures made by this project.
What changed from the previous capture 8 lines
edited: false body: That whole text reads like AI. It couldn't even get to right number of letters in the word "runs" correct. + +comment: p1pd7ia +parent: t1_p1dvgjl +author: magicmulder +created_utc: 1785869183 +edited: false +body: +Most big names are all hat and no cattle. What exactly did he do to warrant that reverence?Extracted text as captured
post: 1vdycb4 author: DyehuthyTV created_utc: 1785717011 title: Coldcard entropy bug: the commits that introduced it are worth reviewing body: Source → X (Tweet): [hodlonaut #BIP-110 on X: "The commits (code changes)..." / X](https://x.com/hodlonaut/status/2083885515229573203) 👀 This is why people should learn to **VERIFY the things they consume**. No excuses! >"I am not a programmer, I don't understand code. How am I supposed to verify?" Learn! With Bitcoin, you are adopting a living standard of verifying everything: **understanding how things really work.** * Economics * Monetary system(fiat money) * Banking system * Investing & Saving * Software * Hardware * Information (facts vs noise) * Privacy * Cybersecurity * etc., etc. This living standard is not just for "paranoids." It is for people who like to do their own research and their own due diligence. **"Don't trust, verify" is not a slogan. It is a living standard!** **"With Bitcoin, you are your own bank."** Well, this is a huge responsibility! It is not a "game." You have to invest a lot of time into **security**, just like banks do. comment: p1czpje parent: t3_1vdycb4 author: CheeseWeezel created_utc: 1785718716 edited: false body: I've never heard of anyone comparing commit message length to the amount of code changes. Every production system I've ever worked on inevitably has an occasional "WIP", "Ugh", or "Crap" commit message - just how it works.Excerpt only. The complete copy is held offline and backs quotations on this site. The original publication remains the canonical public source.
-
Recovered from the Internet Archive rather than captured by this project. The row records that third-party provenance separately from captures made by this project.
What changed from the previous capture 0 lines
Extracted text as captured
post: 1vdycb4 author: DyehuthyTV created_utc: 1785717011 title: Coldcard entropy bug: the commits that introduced it are worth reviewing body: Source → X (Tweet): [hodlonaut #BIP-110 on X: "The commits (code changes)..." / X](https://x.com/hodlonaut/status/2083885515229573203) 👀 This is why people should learn to **VERIFY the things they consume**. No excuses! >"I am not a programmer, I don't understand code. How am I supposed to verify?" Learn! With Bitcoin, you are adopting a living standard of verifying everything: **understanding how things really work.** * Economics * Monetary system(fiat money) * Banking system * Investing & Saving * Software * Hardware * Information (facts vs noise) * Privacy * Cybersecurity * etc., etc. This living standard is not just for "paranoids." It is for people who like to do their own research and their own due diligence. **"Don't trust, verify" is not a slogan. It is a living standard!** **"With Bitcoin, you are your own bank."** Well, this is a huge responsibility! It is not a "game." You have to invest a lot of time into **security**, just like banks do. comment: p1czpje parent: t3_1vdycb4 author: CheeseWeezel created_utc: 1785718716 edited: false body: I've never heard of anyone comparing commit message length to the amount of code changes. Every production system I've ever worked on inevitably has an occasional "WIP", "Ugh", or "Crap" commit message - just how it works.Excerpt only. The complete copy is held offline and backs quotations on this site. The original publication remains the canonical public source.
0 presentation-noise differences. Sidebar, ticker and other page chrome churn that our review classified as not being changes to what the source says.
The excerpts and plain unified diffs above show the text this project held and how it changed. To verify a quotation, compare it against the page itself or against the Internet Archive's copies, which are independent of this project.
Complete captures are held offline rather than mirrored here, so this page shows diffs and excerpts. If a quotation is ever disputed, the full copy can be produced. Ask.
Compare the screenshot or a quotation against the original while it is available.